Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off=>icon #1678

Merged
merged 93 commits into from
Jan 15, 2024
Merged

Off=>icon #1678

merged 93 commits into from
Jan 15, 2024

Conversation

discip
Copy link
Collaborator

@discip discip commented Apr 27, 2023

This PR replaces every Off- / 0-state with this symbol:

unavailable

I initially wanted to reclaim some memory space, but as it turns out, that's not the case here.

In some cases, however, this restores some screen space in places where the actual value is only 2 digits, while space is reserved for 3 digits.

That is, unless the corresponding setting shows Off, the 1-digit-space immediately before the leftmost digit is unusable.

By shortening Off to a symbol that doesn't require a 3-digit-space, there is more room for descriptive text, which is useful for languages ​​with relatively long terms.

I hope this makes sense. 😊

However, if that's not desired, I'll drop this PR.

@discip
Copy link
Collaborator Author

discip commented Dec 27, 2023

@Ralim
Just after I started typing, I noticed that our dear Federico seems to be gone.
So you are the only one left to evaluate this.

Let me know what you want me to change if you don't like it.

@discip
Copy link
Collaborator Author

discip commented Jan 14, 2024

@Ralim
I hope I'm not getting on your nerves, but I need to know if this has a future or if I should just drop it.

thanks in advance

@Ralim
Copy link
Owner

Ralim commented Jan 14, 2024

So the concept has a big 👍🏼

Just the only question is trying to find the icon that is universal.

Could do the android toggle off? Android toggle off

Digging though https://fonts.google.com/icons?icon.style=Outlined to try and find google material design option icons.

One localisation question I've found is that typically over here the slash is in the \ direction, where as disabled tends to use /. Is that just an Australian thing?

In the end your current icon or the empty set version (aka the slash extends outside the circle) may be the simplest one?

@discip
Copy link
Collaborator Author

discip commented Jan 15, 2024

Could do the android toggle off? Android toggle off

I considered this as well, but that would break consistency as we would have to replace the checkbox we otherwise use with a toggle on icon corresponding to the one you suggested.
Additionally, this might confuse people since there is no explicit way to tell whether it means on or off, despite the fact that some use automatic screen orientation.
And on top of that I was not able to find a symbol that checks all the boxes we are looking for in the list you linked.

As you may recall, I've actually changed this icon at least twice, but somehow I'm failing to meet user expectations.
So I ended up with this one, but ... 😅

Even Microsoft and Linux use this symbol in the way we need.

I think we should just implement this into a stable release to see what people think about it, because from my observation there are very few people following the development.
At least no one apart from you and Federico has actively discussed this topic. 😊

@Ralim
Copy link
Owner

Ralim commented Jan 15, 2024

Ah yes good point.

I think I agree, let's ship it and see if anyone shows up with a better suggestion

@discip discip merged commit 8137223 into Ralim:dev Jan 15, 2024
16 checks passed
@discip
Copy link
Collaborator Author

discip commented Jan 15, 2024

Thanks!

What, you are up already?

I was just about to change the symbol after you pointed me to pay attention to the orientation.

I guess I'll have to pull up one more follow up then. 😆

edit:
I changed my mind, the score is about 50 / 50 if you search for unavailable icon.

@discip discip deleted the Off=>Icon branch January 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants