-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Off=>icon #1678
Off=>icon #1678
Conversation
@Ralim Let me know what you want me to change if you don't like it. |
@Ralim thanks in advance |
So the concept has a big 👍🏼 Just the only question is trying to find the icon that is universal. Could do the android toggle off? Digging though https://fonts.google.com/icons?icon.style=Outlined to try and find google material design option icons. One localisation question I've found is that typically over here the slash is in the In the end your current icon or the empty set version (aka the slash extends outside the circle) may be the simplest one? |
I considered this as well, but that would break consistency as we would have to replace the checkbox we otherwise use with a toggle on icon corresponding to the one you suggested. As you may recall, I've actually changed this icon at least twice, but somehow I'm failing to meet user expectations. Even Microsoft and Linux use this symbol in the way we need. I think we should just implement this into a stable release to see what people think about it, because from my observation there are very few people following the development. |
Ah yes good point. I think I agree, let's ship it and see if anyone shows up with a better suggestion |
Thanks! What, you are up already? I was just about to change the symbol after you pointed me to pay attention to the orientation. I guess I'll have to pull up one more follow up then. 😆 edit: |
This PR replaces every
Off
- /0
-state with this symbol:I initially wanted to reclaim some memory space, but as it turns out, that's not the case here.
In some cases, however, this restores some screen space in places where the actual value is only 2 digits, while space is reserved for 3 digits.
That is, unless the corresponding setting shows
Off
, the 1-digit-space immediately before the leftmost digit is unusable.By shortening
Off
to a symbol that doesn't require a 3-digit-space, there is more room for descriptive text, which is useful for languages with relatively long terms.I hope this makes sense. 😊
However, if that's not desired, I'll drop this PR.