Skip to content

Commit

Permalink
Update compilers (#1858)
Browse files Browse the repository at this point in the history
* Update Alpine Image

* Update push.yml

* Style updates
  • Loading branch information
Ralim authored Dec 26, 2023
1 parent 9931afd commit 849d1f7
Show file tree
Hide file tree
Showing 9 changed files with 40 additions and 39 deletions.
44 changes: 23 additions & 21 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,31 @@ name: CI
on: [push, pull_request]

jobs:


build:
runs-on: ubuntu-20.04
container:
image: alpine:3.16
image: alpine:3.19
strategy:
matrix:
model: ["TS100", "TS80", "TS80P", "Pinecil", "MHP30", "Pinecilv2", "S60", "TS101"]
model:
[
"TS100",
"TS80",
"TS80P",
"Pinecil",
"MHP30",
"Pinecilv2",
"S60",
"TS101",
]
fail-fast: true

steps:
- name: Install dependencies (apk)
run: apk add --no-cache gcc-riscv-none-elf gcc-arm-none-eabi newlib-riscv-none-elf newlib-arm-none-eabi findutils python3 py3-pip make git bash
run: apk add --no-cache gcc-riscv-none-elf g++-riscv-none-elf gcc-arm-none-eabi g++-arm-none-eabi newlib-riscv-none-elf newlib-arm-none-eabi findutils python3 py3-pip make git bash

- name: Install dependencies (python)
run: python3 -m pip install bdflib
run: python3 -m pip install --break-system-packages bdflib

- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -58,21 +66,20 @@ jobs:
name: metadata
path: source/Hexfile/${{ matrix.model }}.json


build_multi-lang:
runs-on: ubuntu-20.04
container:
image: alpine:3.16
image: alpine:3.19
strategy:
matrix:
model: ["Pinecil", "Pinecilv2"]
fail-fast: true

steps:
- name: Install dependencies (apk)
run: apk add --no-cache gcc-riscv-none-elf newlib-riscv-none-elf findutils python3 py3-pip make git bash musl-dev
run: apk add --no-cache gcc-riscv-none-elf g++-riscv-none-elf gcc-arm-none-eabi g++-arm-none-eabi newlib-riscv-none-elf newlib-arm-none-eabi findutils python3 py3-pip make git bash musl-dev
- name: Install dependencies (python)
run: python3 -m pip install bdflib
run: python3 -m pip install --break-system-packages bdflib

- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -111,11 +118,10 @@ jobs:
name: metadata
path: source/Hexfile/${{ matrix.model }}_multi-lang.json


tests:
runs-on: ubuntu-20.04
container:
image: alpine:3.16
image: alpine:3.19

steps:
- name: Install dependencies (apk)
Expand All @@ -126,19 +132,18 @@ jobs:
submodules: true

- name: Install dependencies (python)
run: python3 -m pip install bdflib
run: python3 -m pip install --break-system-packages bdflib

- name: Run python tests
run: ./Translations/make_translation_test.py

- name: Run BriefLZ tests
run: make -C source/ Objects/host/brieflz/libbrieflz.so && ./Translations/brieflz_test.py


check_c-cpp:
runs-on: ubuntu-20.04
container:
image: alpine:3.16
image: alpine:3.19

steps:
- name: Install dependencies (apk)
Expand All @@ -151,11 +156,10 @@ jobs:
- name: Check format style with clang-format
run: make clean check-style


check_python:
runs-on: ubuntu-20.04
container:
image: alpine:3.16
image: alpine:3.19

steps:
- name: Install dependencies (apk)
Expand All @@ -166,15 +170,14 @@ jobs:
submodules: true

- name: Install dependencies (python)
run: python3 -m pip install bdflib flake8
run: python3 -m pip install --break-system-packages bdflib flake8

- name: Check python formatting with black
run: black --check Translations

- name: Check python with flake8
run: flake8 Translations


check_shell:
name: check_shell
runs-on: ubuntu-latest
Expand All @@ -188,11 +191,10 @@ jobs:
exclude: "./.git/*" # Optional.
check_all_files_with_shebangs: "false" # Optional.


check_readme:
runs-on: ubuntu-20.04
container:
image: alpine:3.16
image: alpine:3.19

steps:
- name: Install dependencies (apk)
Expand Down
11 changes: 6 additions & 5 deletions scripts/IronOS.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Default Reference Distro for development env & deploy:
# * Alpine Linux, version 3.16 *
FROM alpine:3.16
# * Alpine Linux, version 3.19 *

FROM alpine:3.19
LABEL maintainer="Ben V. Brown <[email protected]>"

# Default current dir when container starts
Expand All @@ -14,7 +15,7 @@ WORKDIR /build/ironos
## - clang (required for clang-format to check C++ code formatting)
## - shellcheck (to check sh scripts)

ARG APK_COMPS="gcc-riscv-none-elf gcc-arm-none-eabi newlib-riscv-none-elf newlib-arm-none-eabi"
ARG APK_COMPS="gcc-riscv-none-elf g++-riscv-none-elf gcc-arm-none-eabi g++-arm-none-eabi newlib-riscv-none-elf newlib-arm-none-eabi"
ARG APK_PYTHON="python3 py3-pip black"
ARG APK_MISC="findutils make git diffutils zip"
ARG APK_DEV="musl-dev clang bash clang-extra-tools shellcheck"
Expand All @@ -25,8 +26,8 @@ ARG PIP_PKGS='bdflib flake8 pymdown-extensions mkdocs mkdocs-autolinks-plugin mk
# Install system packages using alpine package manager
RUN apk add --no-cache ${APK_COMPS} ${APK_PYTHON} ${APK_MISC} ${APK_DEV}

# Install Python3 packages as modules using pip
RUN python3 -m pip install ${PIP_PKGS}
# Install Python3 packages as modules using pip, yes we dont care if packages break
RUN python3 -m pip install --break-system-packages ${PIP_PKGS}

# Git trust to avoid related warning
RUN git config --global --add safe.directory /build/ironos
Expand Down
2 changes: 1 addition & 1 deletion source/Core/BSP/MHP30/system_stm32f1xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void SystemInit(void) {
#ifdef VECT_TAB_SRAM
SCB->VTOR = SRAM_BASE | VECT_TAB_OFFSET; /* Vector Table Relocation in Internal SRAM. */
#else
SCB->VTOR = FLASH_BASE | 0x8000; /* Vector Table Relocation in Internal FLASH. */
SCB->VTOR = FLASH_BASE | 0x8000; /* Vector Table Relocation in Internal FLASH. */
#endif
}

Expand Down
8 changes: 4 additions & 4 deletions source/Core/BSP/Miniware/Setup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ static void MX_TIP_CONTROL_TIMER_Init(void) {
#ifdef TIP_HAS_DIRECT_PWM
sConfigOC.Pulse = 0; // PWM is direct to tip
#else
sConfigOC.Pulse = 127; // 50% duty cycle, that is AC coupled through the cap to provide an on signal (This does not do tip at 50% duty cycle)
sConfigOC.Pulse = 127; // 50% duty cycle, that is AC coupled through the cap to provide an on signal (This does not do tip at 50% duty cycle)
#endif
sConfigOC.OCPolarity = TIM_OCPOLARITY_HIGH;
sConfigOC.OCFastMode = TIM_OCFAST_ENABLE;
Expand All @@ -336,7 +336,7 @@ static void MX_TIP_CONTROL_TIMER_Init(void) {
// Remap TIM3_CH1 to be on PB4
__HAL_AFIO_REMAP_TIM3_PARTIAL();
#else
// No re-map required
// No re-map required
#endif
HAL_TIM_PWM_Start(&htimTip, PWM_Out_CHANNEL);
}
Expand Down Expand Up @@ -480,8 +480,8 @@ static void MX_GPIO_Init(void) {
HAL_GPIO_Init(GPIOA, &GPIO_InitStruct);
#endif
#else
/* TS80 */
/* Leave USB lines open circuit*/
/* TS80 */
/* Leave USB lines open circuit*/

#endif

Expand Down
2 changes: 1 addition & 1 deletion source/Core/BSP/Miniware/system_stm32f1xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void SystemInit(void) {
#ifdef VECT_TAB_SRAM
SCB->VTOR = SRAM_BASE | VECT_TAB_OFFSET; /* Vector Table Relocation in Internal SRAM. */
#else
SCB->VTOR = FLASH_BASE | VECT_TAB_OFFSET; /* Vector Table Relocation in Internal FLASH. */
SCB->VTOR = FLASH_BASE | VECT_TAB_OFFSET; /* Vector Table Relocation in Internal FLASH. */
#endif
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#include "task.h"
#include <stdio.h>

//#define ENABLE_KERNEL_DEBUG
// #define ENABLE_KERNEL_DEBUG

#ifdef ENABLE_KERNEL_DEBUG
#define FREERTOS_PORT_DEBUG(...) printf(__VA_ARGS__)
Expand Down
4 changes: 1 addition & 3 deletions source/Core/BSP/Pinecilv2/ble_peripheral.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,7 @@ static struct bt_gatt_attr ble_attrs_declaration[] = {
NAME
get_attr
*/
struct bt_gatt_attr *get_attr(u8_t index) {
return &ble_attrs_declaration[index];
}
struct bt_gatt_attr *get_attr(u8_t index) { return &ble_attrs_declaration[index]; }

static struct bt_gatt_service ble_tp_server = BT_GATT_SERVICE(ble_attrs_declaration);

Expand Down
2 changes: 1 addition & 1 deletion source/Core/BSP/Sequre_S60/system_stm32f1xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ void SystemInit(void) {
#ifdef VECT_TAB_SRAM
SCB->VTOR = SRAM_BASE | VECT_TAB_OFFSET; /* Vector Table Relocation in Internal SRAM. */
#else
SCB->VTOR = FLASH_BASE | VECT_TAB_OFFSET; /* Vector Table Relocation in Internal FLASH. */
SCB->VTOR = FLASH_BASE | VECT_TAB_OFFSET; /* Vector Table Relocation in Internal FLASH. */
#endif
}

Expand Down
4 changes: 2 additions & 2 deletions source/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ flash_size=128k
bootldr_size=0x0

# Flags
CPUFLAGS=-march=rv32imac \
CPUFLAGS=-march=rv32imaczicsr \
-mabi=ilp32 \
-mcmodel=medany \
-fsigned-char \
Expand Down Expand Up @@ -410,7 +410,7 @@ LDSCRIPT=./Core/BSP/Pinecilv2/bl_mcu_sdk/drivers/bl702_driver/bl702_flash.ld
DEVICE_DFU_ADDRESS=0x23000000
# DFU starts at the beginning of flash
# Flags
CPUFLAGS=-march=rv32imafc \
CPUFLAGS=-march=rv32imafczicsr \
-mabi=ilp32f \
-mcmodel=medany \
-fsigned-char \
Expand Down

0 comments on commit 849d1f7

Please sign in to comment.