Disable OBJECTID capability by default due to #1640

RainLoop · Jun 25, 2024 · c872e5a · c872e5a
1 parent 5a63b02
commit c872e5a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/dev/View/Popup/Domain.js b/dev/View/Popup/Domain.js
@@ -353,7 +353,7 @@ export class DomainPopupView extends AbstractViewPopup {
 			'STATUS=SIZE',
 			'THREAD'
 		]);
-		this.imapDisabled_capabilities(['METADATA','PREVIEW','STATUS=SIZE']);
+		this.imapDisabled_capabilities(['METADATA','OBJECTID','PREVIEW','STATUS=SIZE']);
 		forEachObjectEntry(domainDefaults, (key, value) => this[key](value));
 		this.enableSmartPorts(true);
 		if (oDomain) {

diff --git a/snappymail/v/0.0.0/app/domains/default.json b/snappymail/v/0.0.0/app/domains/default.json
@@ -24,6 +24,7 @@
         },
         "disabled_capabilities": [
             "METADATA",
+            "OBJECTID",
             "PREVIEW",
             "STATUS=SIZE"
         ],

diff --git a/snappymail/v/0.0.0/app/libraries/MailSo/Imap/Traits/Status.php b/snappymail/v/0.0.0/app/libraries/MailSo/Imap/Traits/Status.php
@@ -119,12 +119,12 @@ private function setStatusItem(string $name, $value) : bool
 		}
 		if (\property_exists(__TRAIT__, $name)) {
 			if ('MAILBOXID' === $name) {
-				// https://github.com/the-djmaze/snappymail/issues/1640
 				$value = \is_array($value) ? \reset($value) : $value;
 				if (\is_string($value)) {
 					$this->MAILBOXID = \base64_encode($value);
 				} else {
-					\error_log("{$this->FullName} invalid MAILBOXID value");
+					// Cyrus bug https://github.com/the-djmaze/snappymail/issues/1640
+					\error_log("{$this->FullName} invalid MAILBOXID value. Disable the OBJECTID capability.");
 				}
 			} else {
 				$this->$name = (int) $value;