-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add energy balance KPI block for TEASER building #93
Conversation
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/92-add-kpi-block-for-thermal-zone-kpis/charts |
Thank you for making a Pull Request to BESMod! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me!
@TobiasSpratte : This branch adds a better way to balance a thermal zone. I did not add the block for HOM AixLib, as it would further increase computation time. But this could be done in the future, same in SPAWN.
Can you review this PR? :)
Closes #92