Update README.md #76
Merged
Update README.md #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #74
HvanderStok
requested changes
Apr 19, 2024
README.md
Outdated
| @@ -33,8 +33,10 @@ To install all dependencies, you need python installed (>= 3.7). | |||
| If you don't have python or don't want to install it, just clone the required libraries manually. | |||
| You can extract the relevant information from the `dependencies.cfg` script. | |||
|
|
|||
| Using the script, it's just: | |||
| **Note:** The requirement `Buildings` requires git large-file-storage (`git lfs`). Either install it | |||
| or, in a command line on windows, run: `set GIT_LFS_SKIP_SMUDGE=1`. | |||
There was a problem hiding this comment.
set GIT_LFS_SKIP_SMUDGE is only working if git lfs is already installed.
There was a problem hiding this comment.
Okay, thanks for checking. Can you add a os.system in the python script to raise an error if git lfs is not installed in that case?
HvanderStok
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
I included the check if git lfs is installed and removed the note in the README.
@FWuellhorst you have a look at it and merge it then.
FWuellhorst
commented
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74