Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to save best current result #61 #62

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

jkriwet
Copy link
Contributor

@jkriwet jkriwet commented Oct 2, 2024

During calibration, the current best result should be able to be saved. This enables working with the current best result, while the calibration may still some time to finish

Closes #61

Copy link
Collaborator

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my only comment, otherwise looks good, thanks for the feature

"parameters": parameter_values,
"objective": total_res
}
with open(self.working_directory / 'best_iterate.json', 'w') as json_file:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use self.working_directory.joinpath("best_iterate.json")?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ is equivalent to joinpath and in my opinion better readable for chained operations. But changed it anyway to joinpath, because this is mainly used in the rest of the code.

@jkriwet jkriwet merged commit fb1756c into master Oct 16, 2024
@jkriwet jkriwet deleted the 61-option-to-save-current-best-result branch October 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add option to always save the current best result while calibrating
2 participants