Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang format #263

Open
wants to merge 2 commits into
base: asar_2_beta
Choose a base branch
from
Open

Clang format #263

wants to merge 2 commits into from

Conversation

bonimy
Copy link

@bonimy bonimy commented Sep 24, 2022

clang-format all source files

All files were formatted with the command at repository root:
find ./ -iname *.h -o -iname *.cpp | xargs clang-format -i

.clang-format contents:

---
Language: Cpp
BasedOnStyle: Google
ColumnLimit: 88
IndentWidth: 4
AccessModifierOffset: -4
SortIncludes: true
ConstructorInitializerIndentWidth: 8
ContinuationIndentWidth: 8
DerivePointerAlignment: false
MaxEmptyLinesToKeep: 2
...

To help with automerging, you will need to run this same command with
the same formatting rules on your own branch. Then commit those changes,
and then finally merged

@bonimy bonimy changed the base branch from master to asar_2_beta September 24, 2022 01:24
All files were formatted with the command at repository root:
`find ./ -iname *.h -o -iname *.cpp | xargs clang-format -i`

.clang-format contents:
---
Language: Cpp
BasedOnStyle: Google
ColumnLimit: 88
IndentWidth: 4
AccessModifierOffset: -4
SortIncludes: true
ConstructorInitializerIndentWidth: 8
ContinuationIndentWidth: 8
DerivePointerAlignment: false
MaxEmptyLinesToKeep: 2
...

To help with automerging, you will need to run this same command with
the same formatting rules on your own branch. Then commit those changes,
and then finally merged
One feature of clang-format is auto-sorting #includes. This has the
side-effect of breaking files that don't properly include headers in a
self-contained way.
@bonimy bonimy force-pushed the clang-format branch 2 times, most recently from 04d5627 to b2f23ab Compare September 24, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant