New API: tw_opt_set #163
Closed
New API: tw_opt_set #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes warnings when building with -Wall and -Wextra. In addition, removes old unused code related to prior pthread versions of ROSS as well as removing the ROSS_MEMORY related code, due to no longer being fully functional. * fixing warnings when building with Wall, etc * fixing warnings in buddy.c * fixing warnings in the rest of ROSS core * fixing warnings in instrumentation * fixing warnings with phold * fixing undefined reference causing linking error * adding warning flags to Travis builds * fixing some additional warnings that appear in release builds * minor changes to travis builds * removing old, unnecessary pthread related code * fixing ifdefs for ROSS_MEMORY * removing tw-memory related stuff for now * removing some unused stuff and unnecessary function arguments * lots of documentation for network-mpi and removing some unnecessary stuff * keeping the ROSS models submodule from being used in Travis tests * minor fix for C++ Travis build * adding installing phold to bin * adding some RPATH commands to CMakeLists.txt for Spack * removed ROSS-Models and template model submodule * update readme for submodule details * rpath in pkg-config * adding develop branch to Travis safelist
* updating the way the version number is grabbed, so we can have the actual version and not the git commit * fixing an error that caused coveralls to fail
* see if gcov and clang versions match * maybe we should be using lcov... since we apt-get it * whitespace * what version is llvm-cov? * use llvm-cov * llvm-cov gcov * remove cov version checks
… as well as having ROSS output both version number and commit, instead of just version
This commit adds support for the ARM v7 core architecture (armv7l) to ROSS Timing. Note that because cycle counter from the PMU is not accessible from userspace by default, a kernel module is required to enable that feature. An example kernel module that achieves this can be found: https://github.com/nmcglohon/armv7l-userspace-counter.git
now takes size / length of queue argument, rather than an embedded if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new API function which can be used to set options during runtime (any options that are registered with TWOPT). It may be useful for models that always require certain options.
This is also a step in the direction of formalizing the ROSS API and removing the need for models to muck with global variables. The hope is that models only worry about options documented by
--helptext and never need to rememberg_tw_xxxvariables.Some larger discussion should take place in #162.
If this merge represents a feature addition to ROSS, the following items must be completed before the branch will be merged:
Include a link to your blog post in the Pull Request.