Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official Jekyll image, for longevity #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mav8557
Copy link
Member

@mav8557 mav8557 commented Feb 1, 2022

Proposing this switch to the official docker image for Jekyll, in case bretfisher stops maintaining his image. This docker-compose file still allows for live updates to the running site as you work on it.

Copy link
Member

@d3adzo d3adzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mav8557 mav8557 requested a review from BradHacker April 13, 2022 21:50
Copy link
Contributor

@BradHacker BradHacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ask Jon B about version pinning, 11/10 would recommend.

@mav8557
Copy link
Member Author

mav8557 commented Apr 13, 2022

Looks good. Ask Jon B about version pinning, 11/10 would recommend.

I forgor 💀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants