Filter HTTP Basic Authorisation Credential in Update Audit Log #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # whois-api/src/main/java/net/ripe/db/whois/api/apiKey/BearerTokenExtractor.java # whois-api/src/main/java/net/ripe/db/whois/api/rest/WhoisServletDeployer.java # whois-api/src/test/java/net/ripe/db/whois/api/ApiKeyAuthServerDummy.java # whois-api/src/test/java/net/ripe/db/whois/api/rest/WhoisRestApiKeyAuthTestIntegration.java # whois-api/src/test/java/net/ripe/db/whois/api/rest/WhoisSearchServiceTestIntegration.java # whois-update/src/main/resources/templates/notification.vm # whois-update/src/test/java/net/ripe/db/whois/update/handler/response/ResponseFactoryTest.java
maggarwal13
requested review from
eshryane,
fmurodov,
isvonja and
MiguelAHM
as code owners
eshryane
reviewed
Jan 9, 2025
| "delete: adsf\n"; | ||
|
|
||
| assertThat(PasswordFilter.filterPasswordsInContents(input), containsString("" + | ||
| "Header: Authorization=Basic FILTERED\n" + |
There was a problem hiding this comment.
There are two spaces in the output, but the regex doesn't appear to include any spaces in the matching group?
There was a problem hiding this comment.
removed one space
eshryane
changed the title
eshryane
reviewed
Jan 10, 2025
| private static String replaceBasicAuthHeader(final Matcher matcher) { | ||
| final StringBuilder result = new StringBuilder(); | ||
| while (matcher.find()) { | ||
| matcher.appendReplacement(result, String.format("%s%s", StringUtils.substringBefore(matcher.group(0), matcher.group(1)),"FILTERED")); |
There was a problem hiding this comment.
The regex is still matching a space? Can you use (.*) as the group in the pattern instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.