Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: re-enable utf-8 tests on native #12246

Merged
merged 1 commit into from
Sep 16, 2019
Merged

tests: re-enable utf-8 tests on native #12246

merged 1 commit into from
Sep 16, 2019

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Sep 16, 2019

Contribution description

The docker image should now be configured with LC_ALL|LANG=C.UTF-8
and used in murdock.

Now that RIOT-OS/riotdocker#75 is merged, the tests should run again in murdock

Closes #11691

Testing procedure

The 'native' tests work in murdock

Issues/PRs references

murdock and tests using utf-8 characters #11691
Fix in riotdocker RIOT-OS/riotdocker#75

@cladmi
tests: re-enable utf-8 tests on native
be7ce7e 
The docker image should now be configured with LC_ALL|LANG=C.UTF-8
and used in murdock.
@cladmi cladmi mentioned this pull request Sep 16, 2019
Closed
@miri64 miri64 added the Platform: native Platform: This PR/issue effects the native platform label Sep 16, 2019
@miri64 miri64 requested a review from kaspar030 September 16, 2019 13:55
@miri64 miri64 added Area: tests Area: tests and testing framework Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 16, 2019
miri64
miri64 approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more straight-forward than my first glance at this PR made me suspect. ACK (and go when Murdock passes).

@cladmi
Copy link
Contributor Author

cladmi commented Sep 16, 2019

This is more straight-forward than my first glance at this PR made me suspect. ACK (and go when Murdock passes).

All the fixes were done somewhere else :)

Only need to be sure the tests are executed correctly, but I think it is always the case with native even without run tests.

@miri64
Copy link
Member

miri64 commented Sep 16, 2019

All the fixes were done somewhere else :)

Only need to be sure the tests are executed correctly, but I think it is always the case with native even without run tests.

Yes.

@miri64
Copy link
Member

miri64 commented Sep 16, 2019 •
edited
Loading

The tests in question now pass with Murdock:

(the output looks broken, but I guess that is due to my browser defaulting to some non-UTF-8 stuff)

@miri64 miri64 merged commit a3375db into RIOT-OS:master Sep 16, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Sep 16, 2019

It is indeed the encoding that is not set by murdock. #9095 (comment)

Thank you for the review. Less blacklisted tests!

@cladmi cladmi deleted the pr/tests/re_enable_utf8_tests branch September 16, 2019 15:31
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.

murdock and tests using utf-8 characters
3 participants
@cladmi @miri64 @kb2ma