Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better string formatting, format table better #26

Merged
merged 6 commits into from
May 29, 2024
Merged

Conversation

trappitsch
Copy link
Contributor

  • string formatting in table via rttools
  • format transition strength as html
  • fix tests
  • split terms into separate table entries
  • update deps, fix failing tests with new table format

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.00%. Comparing base (de77be5) to head (9fb4e5a).
Report is 9 commits behind head on main.

Files Patch % Lines
src/rimsschemedrawer/json_parser.py 93.02% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   94.12%   94.00%   -0.12%     
==========================================
  Files           9        9              
  Lines         715      751      +36     
==========================================
+ Hits          673      706      +33     
- Misses         42       45       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trappitsch trappitsch merged commit 31d00c9 into main May 29, 2024
7 checks passed
@trappitsch trappitsch deleted the string_formatter branch May 29, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant