Update gs_cyto_data<- to support replacement with flowSet objects. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejiang
requested changes
Mar 24, 2023
| @@ -528,6 +528,9 @@ setReplaceMethod("flowData",signature(x="GatingSet"),function(x,value){ | |||
| #' @rdname gs_cyto_data | |||
| #' @export | |||
| setReplaceMethod("gs_cyto_data",signature(x="GatingSet"),function(x,value){ | |||
| if(class(value) != "cytoset") { | |||
There was a problem hiding this comment.
maybe add type checking and throw user-friendly error if it's not flowset
There was a problem hiding this comment.
Apologies for the delay @mikejiang, I have added additional type checks to ensure value is a flowSet or cytoset only. I will submit another PR after this one to fix some other inconsistency issues I have encountered.
mikejiang
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised #372 where
gs_cyto_data()replacement method no longer works forflowSetobjects.We don't want to remove support for
flowSetobjects just yet as many users/developers still createGatingSetobjects by passing inflowSetobjects - so we need to provide replacement method that supportsflowSetobjects too.To fix this, we perform a class check on
valueand if it isn't acytosetwe convert it usingflowSet_to_cytoset()before updating it in the GatingSet.Successfully tested locally with
flowSet,ncdfFlowSetandcytosetreplacement values.