Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spend 2 assets with different close methods #24

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

St333p
Copy link
Contributor

@St333p St333p commented Nov 19, 2024

This PR adds a new test that uses 2 taproot wallets to issue 2 assets on the same UTXO, spends the first one and checks that the second one is still spendable after going through a blank transition.

The second pay() (which should spend the blank allocation from the previous transfer) fails in some cases, with different errors depending on the selected close methods for the two assets:

  • both tapret: success
  • both opret: pay() fails with Composition(Stock("the spent UTXOs contain too many seals which can't fit the state transition input limit."))
  • send opret, blank tapret: pay() fails with Composition(Stock("the spent UTXOs contain too many seals which can't fit the state transition input limit."))
  • send tapret, blank opret: pay() fails with Composition(Construction(NoInputs))

@St333p St333p force-pushed the blank_tapret_opret branch from 77af269 to 457b51b Compare November 25, 2024 09:50
@St333p
Copy link
Contributor Author

St333p commented Nov 25, 2024

Rebased on top of master and added the ignore flag to the failing cases as per README instructions

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.23%. Comparing base (67c6b65) to head (457b51b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   37.23%   37.23%   -0.01%     
==========================================
  Files         279      279              
  Lines       42806    42806              
==========================================
- Hits        15938    15937       -1     
- Misses      26868    26869       +1     
Flag Coverage Δ
rust 37.23% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zoedberg zoedberg merged commit 6d8e53b into RGB-WG:master Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants