Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects columns of Pull Requests in milestone projects #1199

Merged

Conversation

Ryan089
Copy link
Contributor

@Ryan089 Ryan089 commented May 15, 2023

Summary

Edits previous workflow to place PR to the appropriate project column (In Progress / In Review) when it has been given a milestone. Previously PR's were placed in the Backlog column.

Changes to Files

Created custom action: determine-status-column
Edited workflow AddIssueToMilestoneProject

Limitations

I didn't go to the effort of checking whether the PR is open or not in this workflow. If essential functionality, I offer this as an exercise for an alternate contributor. My strong recommendation is just do not add milestones to PR's that are already closed (because: why would you need to do that??)

Fixes

Contributes to #1112 by completing the following task:

  • When a GitHub Milestone is added to an open PR (develop repo):
    • if the PR has "WIP" in the title
      • add the PR to the GH Project of the same name as the Milestone, in the 'in progress' column
    • else
      • add the PR to the GH Project of the same name as the Milestone, in the 'in review' column

Copy link
Member

@cosmiccoincidence cosmiccoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code/files look good.

Obviously I cant test it until after it is merged though.

@cosmiccoincidence cosmiccoincidence merged commit 99947c3 into RE-SS3D:develop May 15, 2023
@cosmiccoincidence
Copy link
Member

Tested. Works well. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants