Create default public key endpoint for radar-gateway #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
keyvaann
reviewed
Oct 24, 2024
| @@ -57,6 +57,7 @@ data: | |||
| managementPortalUrl: {{ .Values.managementportal_url }} | |||
| checkSourceId: {{ .Values.checkSourceId }} | |||
| publicKeyUrls: | |||
| - {{ printf "%s://%s/managementportal/oauth/token_key" .Values.advertised_protocol .Values.serverName | quote }} | |||
There was a problem hiding this comment.
Should this line always be present?
There was a problem hiding this comment.
@keyvaann I think so yes.
There was a problem hiding this comment.
@keyvaann Ah I think that I understand where your question comes from. This is related to the error that is thrown by gateway when using this config option. Shall I enable this via config option and have it off by default?
There was a problem hiding this comment.
@keyvaann I have added the option to disable the publicKeyUrls config option.
pvannierop
force-pushed
the
bugfix/gateway-public-key-endpoints
branch
2 times, most recently
from
61c0b74
to
c91cf51
Compare
|
@pvannierop The lint is failing. |
Fixes a config error introduced by prior PR.
pvannierop
force-pushed
the
bugfix/gateway-public-key-endpoints
branch
from
c91cf51
to
6dd64fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previous PR introduced public key endpoint for radar-gateway. This implementation did not include config for a sensible default value.
Solution
This PR will provide a default value that respects the protocol (http, https) which is needed for local testing.