Separate advertised protocol (http, https) from disabling TLS #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pvannierop
force-pushed
the
feature/external-uri-protocol-value
branch
from
afa1ef6
to
2c8af94
Compare
pvannierop
force-pushed
the
feature/external-uri-protocol-value
branch
from
2c8af94
to
3d9d2ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When instructing the ingress to not demand TLS, the advertised protocol (HTTP, HTTPS) would switch to HTTP. This was ok for local testing, but was not desired for when TLS termination is handled by upstream component; services behind TLS termination would advertise an incorrect URI.
Solution
This PR separates the options for TLS termination from the advertised protocol.