-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update egress network policy of some charts #116
Conversation
- Truncate postgres podselector so that it is within 63 character limit
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
@yatharthranjan @keyvaann This issue comes up because we are using AWS RDS so the hostname is greater than 63 characters. But I think this egress is only applicable if the postgres is hosted in the cluster? This solution is truncating that host name. Is this fine? Or is it better to check if postgres is installed instead? I feel that manually replacing the network policies would be too much duplication for each chart (for example if we replace this in production.yaml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is k8s permitting the use of a trailing wildcard following the truncated to match the entire value?
Thanks @mpgxvii! |
I don't think so, especially when we're using |
@keyvaann Oh ok I see. Thanks! Yes it is private for our installation. |
In that case we might need to remove the section that blocks the connection to local network. Would you be able to test if it works on your installation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh ok I see. Yeah it seems to be working without removing the block. |
That's good. I'll try to investigate this at some point. |
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.