Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fitbit oxygen saturation #364

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Add Fitbit oxygen saturation #364

merged 3 commits into from
Mar 6, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Mar 5, 2024

  • Add Fitbit intraday spo2 to schemas and specifications

Copy link
Member

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the tests pass :)

"namespace": "org.radarcns.connector.fitbit",
"type": "record",
"name": "FitbitIntradaySpo2",
"doc": "Intra day spo2 data from fitbit device.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add more info from the webapi docs (esp regarding that spo2 is mainly calculated during sleep periods)

Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpgxvii mpgxvii merged commit 086b7b6 into dev Mar 6, 2024
3 checks passed
@mpgxvii mpgxvii deleted the add-fitbit-spo2 branch March 6, 2024 12:15
@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants