-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ory hydra #280
Conversation
1769208
to
425834b
Compare
2d6e8eb
to
30e7467
Compare
adc0223
to
4032404
Compare
@pvannierop are there any plans on progressing this from the hyve? |
@pvannierop never mind, I am starting work on this now. Thanks. |
@mpgxvii can you please add the webhook jsonnet body and the updated identities please? |
Added the identities and added the webhook jsonnet to the configmap here: RADAR-base/radar-helm-charts#260. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if someone else can review too, then I will proceed with the merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Waiting on this release: RADAR-base/radar-helm-charts#262, then will merge. |
@mpgxvii I tried to update our instance with changes from this PR and I get these messages:
Also Helmfile sends this warning:
|
Hi @keyvaann, this is fixed, but it wasn't merged to the |
Hi @mpgxvii, how should I apply the fix? |
@keyvaann Oh the permission issue is now fixed but I think the healthcheck need to be temporarily disabled since those changes are not yet merged. I'll open a PR for the updated values. |
Description of the change
Add ory-hydra as a component
Benefits
We can move away from managementportal as a resource server
Possible drawbacks
Applicable issues
Additional information
This is a stub/WIP
Checklist