fit_IsothermalHolding(): define the models as functions rather than strings #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary as the BTS model uses
integrate()
, and in order to retrieve its result one needs to extract$value
from the object it returns. But this confusesnlsLM()
into thinking thatvalue
is a parameter to be optimized and for which a starting point should be given.The only workable solution seems to hide all that complexity into a wrapper function (
f_BTS)
that is used as right-hand side in the formula. Because of this, we need to reformulate alsof_GOK
as a function.Due to R's abstruse way of accessing variables in the environment from inside a function, it turns out that we can access
rhop
but notisoT
, so we have to addisoT
to the model signatures and also to thedata
argument.This commit also introduces some changes to the BTS model: in particular we now use
sapply()
insidef_BTS()
, and also fixDeltaE
to 1.5eV as suggested from the Li&Li paper. However, even with these changes the model doesn't fit, but reports this error: