Silverfish Infestation Logging #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging for Silverfish infestation and breaking of blocks. When a Silverfish infests a Stone/Deepslate/Stone Bricks block, it will be logged as a block change action. If a Silverfish breaks out of a block, that will now be logged as a block break action.
This was motivated by a video that came out recently about Silverfish mining. When testing this myself, I found that Ledger did not log Silverfish breaking or replacing stone and infested stone. Seeing as this is probably something technical players will want to do in 1.21, I thought it would be worth adding to Ledger.
Silverfish mining video: https://youtu.be/1zS-vKKWR94?si=LIh2bkU0URnBrW0o