Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix itemstack count in 1.20.5 and higher #272

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

DrexHD
Copy link
Contributor

@DrexHD DrexHD commented Jun 16, 2024

Reworked item data fixing to yield correct 1.20.5+ item nbt for old and new entries. It broke because it didn't take into consideration that 1.20.5 changed the Count field to count

  • 1.20.5+ (detected by presence of "count" field) are not modified
  • 1.20.4-
    • Add id field (was omitted in 1.20.4 ledger stacks, because it can be extracted through object id)
    • Set Count to 1 if it is not present (was omitted in 1.20.4 ledger stacks, because non present indicated count 1)
    • Most importantly: Apply ItemStackComponentizationFix

@DrexHD DrexHD requested a review from a team as a code owner June 16, 2024 19:42
@PotatoPresident PotatoPresident merged commit d14b0a8 into master Jun 18, 2024
2 checks passed
@PotatoPresident PotatoPresident deleted the fix/itemstack-count branch June 18, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants