Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: item components based item logging, standalone column count for items and events #267

Closed

Conversation

zly2006
Copy link
Contributor

@zly2006 zly2006 commented Jun 2, 2024

In this PR:

  • added column itemData for item components, count for item count
  • turned item-insert and item-remove into one event: item-change
  • for events in the queue, try to squash them into one event to reduce events logged

@zly2006
Copy link
Contributor Author

zly2006 commented Jun 2, 2024

Hello @PotatoPresident @DrexHD
I want to change the type of timestamps from TEXT to BIGINT, is there any reason why not to use BIGINT for timestamps? for human reading?

One of the problems this PR tries to solve is that some client-side mods that help players to sort items, will produce a very spammy log when the player sorts items in a chest. imo we can also prevent spamming entity-kill logs for farms by squashing them into one event. To achieve this, the timestamp has to be divided into start and end two timestamps, and a count field is used to log how many events like this happened. The messages and i18n should also be updated.

…-item-components

# Conflicts:
#	src/main/kotlin/com/github/quiltservertools/ledger/database/DatabaseManager.kt
@DrexHD
Copy link
Contributor

DrexHD commented Oct 13, 2024

Superseded by #275

@DrexHD DrexHD closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants