-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support next@15
#426
Conversation
@blechatellier is attempting to deploy a commit to the Tom Labs Team on Vercel. A member of the Team first needs to authorize it. |
@QuiiBz hey, would appreciate a review when available to be able to upgrade to next@15 |
☝️ I there a possibility to merge it ASAP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry for the delay, I'm travelling away for a few days.
Since Next.js 15 contains several breaking changes to dynamic APIs and next-international
's v2 version is still wip (I'm planning to work on it soon), we need to support both Next.js 14 and 15 on [email protected]
. It might already just work with those changes in both versions given JavaScript allows non-promise values to be await
'ed, but we need to double-check.
I left a comment for the next-app
example that is currently broken, and the documentation also needs to be updated. I'll be able to do it on Monday once I'm back home, but feel free to update the PR before if you can so we can support Next.js 15 asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example needs to be updated, as the page is accessing params.locale
without await
ing it.
@QuiiBz thanks, I've updated the docs and example. |
nice one blechatellier. was about to make a PR too. thanks a lot! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the docs to still show how to use next-international with Next.js < 15, but the default will be with the new await
able APIs.
I'm releasing [email protected]
shortly after merging this PR, thanks!
edit: it's live: https://github.com/QuiiBz/next-international/releases/tag/1.3.0
Thanks @QuiiBz |
Did you miss the type safety for |
This PR updates
next-international
to support async changes innext@15
.