Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add darkmode #243

Merged
merged 13 commits into from
Oct 14, 2023
Merged

feat(docs): add darkmode #243

merged 13 commits into from
Oct 14, 2023

Conversation

Willem-Jaap
Copy link
Contributor

Nextra has a nice built-in darkmode, this pr enables it along with some small fixes

  • feat: enable darkMode
  • fix: update svg regex to match actual pattern in imports file
  • feat: add logo component with darkmode support, fix import and formatting

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-international ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 1:31pm

@Willem-Jaap
Copy link
Contributor Author

I upgraded deps, looks like that breaks linting, I'll take a look when I have the time

Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Some suggestions:

pnpm-lock.yaml Outdated Show resolved Hide resolved
docs/pages/index.mdx Outdated Show resolved Hide resolved
@QuiiBz QuiiBz changed the title Darkmode feat(docs): add darkmode Oct 14, 2023
Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuiiBz QuiiBz merged commit c3f55b1 into QuiiBz:main Oct 14, 2023
5 checks passed
@Willem-Jaap Willem-Jaap deleted the darkmode branch October 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants