Re-adding features to V2 architecture #1205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieciu
requested review from
nablaone,
jakozaur,
trzysiek,
avelanarius and
pdelewski
pdelewski
reviewed
Jan 22, 2025
| } | ||
|
|
||
| func (qmc *QuesmaManagementConsole) elasticsearchResolveIndexPattern(ctx context.Context, indexPattern string) (sources elasticsearch.Sources) { | ||
| resp, err := qmc.elasticsearch.RequestWithHeaders(ctx, "GET", "_resolve/index/"+indexPattern+"?expand_wildcards=open", nil, nil) |
There was a problem hiding this comment.
nitpick: The same uri is used in https://github.com/QuesmaOrg/quesma/blob/main/quesma/elasticsearch/index_resolver.go#L56
Maybe, we can extract common const?
pdelewski
reviewed
Jan 22, 2025
| @@ -48,3 +49,46 @@ func (t DummyTableResolver) Pipelines() []string { return []string{} } | |||
| func (t DummyTableResolver) RecentDecisions() []mux.PatternDecisions { | |||
| return []mux.PatternDecisions{} | |||
| } | |||
|
|
|||
| //func (t DummyTableResolver) resolveWildcardCommonTable(indexPattern string) *mux.Decision { | |||
pdelewski
reviewed
Jan 22, 2025
| @@ -73,12 +74,14 @@ func (p *ElasticsearchToClickHouseQueryProcessor) prepareTemporaryQueryProcessor | |||
| logManager := clickhouse.NewEmptyLogManager(p.legacyDependencies.OldQuesmaConfig, p.legacyDependencies.ConnectionPool, p.legacyDependencies.PhoneHomeAgent(), p.legacyDependencies.TableDiscovery) | |||
| logManager.Start() | |||
|
|
|||
| abTestingController := sender.NewSenderCoordinator(p.legacyDependencies.OldQuesmaConfig) | |||
There was a problem hiding this comment.
Should not we create and start this Coordinator earlier? and pass it to Init()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some (a lot of) shortcuts to merge v2 architecture processors. Now it's time to take the high road.
Changes:
IndexManagement(the only component which depends on it isTableResolverClickHouse Ingesterinterface @nablaone