Change the end of very long window titles to ...
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimirjamali
force-pushed
the
issue-5986-long-titles
branch
from
d5ce1ad
to
d3f1682
Compare
marmarek
requested changes
Nov 12, 2024
| @@ -2912,6 +2912,12 @@ static void handle_wmname(Ghandles * g, struct windowdata *vm_window) | |||
| read_struct(g->vchan, untrusted_msg); | |||
| /* sanitize start */ | |||
| untrusted_msg.data[sizeof(untrusted_msg.data) - 1] = 0; | |||
| /* change the end of very long window titles to ... */ | |||
| if (strlen(untrusted_msg.data) == (sizeof(untrusted_msg.data) - 1)) { | |||
There was a problem hiding this comment.
Shouldn't this be done on the agent side instead? It knows where the limit is too, and may have more info (especially, if it really was truncated or maybe just at the limit).
There was a problem hiding this comment.
Shouldn't this be done on the agent side instead? It knows where the limit is too, and may have more info (especially, if it really was truncated or maybe just at the limit).
I did it on the agent side at the beginning. I am going to change this PR to draft and do it properly, writing the main patch for both agent and xside to have the length increased (from 128 to 4096) as well as appending ... if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: QubesOS/qubes-issues#5986