Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events with flags #12

Closed
wants to merge 3 commits into from
Closed

Add events with flags #12

wants to merge 3 commits into from

Conversation

iacore
Copy link

@iacore iacore commented Feb 23, 2022

@DemiMarie
Copy link
Contributor

  • Please sign your most recent commit (see the No signature found error message).
  • This will require corresponding changes to the GUI daemon and agent.

Comment on lines +110 to +114
enum {
FLAG_BUTTON_EMULATED=0b1,
};
enum {
FLAG_MOTION_EMULATED=0b1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those flags actually useful for an application in the VM? It may be seen as a feature that VM has no idea whether event was emulated or not

Copy link
Author

@iacore iacore Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Mouse wheel events are mapped as motion and emulated button presses (the amount of presses per "unit" of wheel scrolled is adjustable in Windows, there are tools for doing it for X11). Some games rely on motion events, and get insane mouse wheel speed when they can't filter emulated mouse wheel events out.

Copy link
Author

@iacore iacore Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't send repeated or emulated events to client VMs, and let the client generate those events themselves? This way, each client can have different key repeat intervals.

@iacore
Copy link
Author

iacore commented Feb 24, 2022

  • Please sign your most recent commit (see the No signature found error message).
    Thanks. I'll sign the last commit.

@iacore
Copy link
Author

iacore commented Feb 24, 2022

Closing, because I discovered that repeated events are not necessary as clients can generate those themselves.

@iacore iacore closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants