-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add events with flags #12
Conversation
|
enum { | ||
FLAG_BUTTON_EMULATED=0b1, | ||
}; | ||
enum { | ||
FLAG_MOTION_EMULATED=0b1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those flags actually useful for an application in the VM? It may be seen as a feature that VM has no idea whether event was emulated or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Mouse wheel events are mapped as motion and emulated button presses (the amount of presses per "unit" of wheel scrolled is adjustable in Windows, there are tools for doing it for X11). Some games rely on motion events, and get insane mouse wheel speed when they can't filter emulated mouse wheel events out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't send repeated or emulated events to client VMs, and let the client generate those events themselves? This way, each client can have different key repeat intervals.
|
Closing, because I discovered that repeated events are not necessary as clients can generate those themselves. |
QubesOS/qubes-issues#7231