device identity #304
device identity #304
Conversation
piotrbartman
force-pushed
the
qdev/devel
branch
from
9a7ff4b
to
0168517
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 75.10% 75.19% +0.08%
==========================================
Files 52 52
Lines 8552 8893 +341
==========================================
+ Hits 6423 6687 +264
- Misses 2129 2206 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
piotrbartman
force-pushed
the
qdev/devel
branch
from
2c86f03
to
2db1c50
Compare
Listing all assignments by default could be overwhelming. Now to see all assignment a flag `-s` must be used. Assignments are indicated by '*' before qube name.
Even if device is `auto-attached` it could be manually reattached, so to avoid confusion just show as `attached`
piotrbartman
force-pushed
the
qdev/devel
branch
from
22aac29
to
05115ae
Compare
|
Changes here looks okay, but I haven't tried running this version yet. |
|
Important note on breaking backward compatibility: there may exists scripts using |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111214-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests63 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable tests
|
|
|
but |
qubesadmin/device_protocol.py
Outdated
| "u10****", | ||
| "p03****", | ||
| "p04****", | ||
| ) | ||
| Wireless = ("ue0****", "p0d****") | ||
| Bluetooth = ("ue00101", "p0d11**") | ||
| Mass_Data = ("b******", "u08****", "p01****") |
There was a problem hiding this comment.
I'm not sure which PR is the right one to comment, but "Mass_Data" prefix in devices widget is IMO not very intuitive (but should be fine on the API level). Maybe better "Storage" or "Disk"? @marmarta any other ideas? This is how it looks: https://openqa.qubes-os.org/tests/116595#step/qui_widgets_devices/6
There was a problem hiding this comment.
Yes Mass_Data is not something useful, I would go with Storage.
There was a problem hiding this comment.
I agree, it is already changed ;)
There was a problem hiding this comment.
Sorry for the noise, I saw it after my comment.
`qvm-device *CLASS*` should list all available *CLASS* devices
|
Categories cont. - see https://openqa.qubes-os.org/tests/118678#step/qubesmanager_vmsettings/60 |
implements QubesOS/qubes-issues/issues/9325