Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timing group visibility #196

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add timing group visibility #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Quaver.API/Maps/Structures/TimingGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,18 @@
/// to the <see cref="Id"/> of the desired <see cref="TimingGroup"/>.
/// </summary>
[MoonSharpUserData]
public abstract class TimingGroup

Check warning on line 19 in Quaver.API/Maps/Structures/TimingGroup.cs

View workflow job for this annotation

GitHub Actions / build 

'TimingGroup' overrides Object.Equals(object o) but does not override Object.GetHashCode()

Check warning on line 19 in Quaver.API/Maps/Structures/TimingGroup.cs

View workflow job for this annotation

GitHub Actions / build 

'TimingGroup' overrides Object.Equals(object o) but does not override Object.GetHashCode()
{
/// <summary>
/// The color of the layer (default is white)
/// </summary>
public string ColorRgb { get; [MoonSharpVisible(false)] set; }

/// <summary>
/// Is the timing group hidden in the editor?
/// </summary>
public bool Hidden { get; [MoonSharpVisible(false)] set; }

/// <summary>
/// Converts the stringified color to a System.Drawing color
/// </summary>
Expand All @@ -42,7 +47,7 @@
/// <returns></returns>
protected bool Equals(TimingGroup other)
{
return ColorRgb == other.ColorRgb;
return ColorRgb == other.ColorRgb && Hidden == other.Hidden;
}

/// <summary>
Expand Down
Loading