-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timing groups #186
Merged
Merged
Add timing groups #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Default HitObjectInfo.TimingGroup to "" instead of null
…reference in hit objects
…e opposite afterwards to end the need of having to distinguish between null and GlobalTimingGroupId Add timing group parameter in GetScrollVelocityAt
Swan
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure that if there are no timing groups, it doesn't get written to the file.
TimingGroups: {}
should not be here.
This will cause a md5 hash mismatch which can have negative side effects like leaderboards not working on older/converted maps.
… global group is empty
Swan
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timing groups to
Qua
files.tl;dr: you can now have independent groups of notes that use different sets of SVs.
A timing group is a controller of hit objects. A hit object can choose to reside in one and only one timing group (and a timing group can have multiple hit objects). The timing group defines the way the hit objects inside it visually changes as time goes by.
Each timing group has a unique ID, consisting of alphanumerical characters including _. HitObjects refer to the group using the ID.
A
ScrollGroup
is derived from timing group and will drive notes with its own list of SVs and InitialSV, for example.Further development might extend this so that the visual of the note can be directly controlled by lua scripts.
Additions
Qua.ScrollGroups
: list of scroll groups