Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timing groups #186

Merged
merged 21 commits into from
Nov 2, 2024
Merged

Add timing groups #186

merged 21 commits into from
Nov 2, 2024

Conversation

WilliamQiufeng
Copy link
Member

This PR adds timing groups to Qua files.

tl;dr: you can now have independent groups of notes that use different sets of SVs.

A timing group is a controller of hit objects. A hit object can choose to reside in one and only one timing group (and a timing group can have multiple hit objects). The timing group defines the way the hit objects inside it visually changes as time goes by.

Each timing group has a unique ID, consisting of alphanumerical characters including _. HitObjects refer to the group using the ID.

A ScrollGroup is derived from timing group and will drive notes with its own list of SVs and InitialSV, for example.

Further development might extend this so that the visual of the note can be directly controlled by lua scripts.

Additions

  • Qua.ScrollGroups: list of scroll groups
  • HitObjectInfo.TimingGroup`: the ID of the timing group this hit object belongs to. If not specified or left empty, the default group is used.

@WilliamQiufeng WilliamQiufeng marked this pull request as ready for review October 25, 2024 11:05
Copy link
Member

@Swan Swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that if there are no timing groups, it doesn't get written to the file.

TimingGroups: {} should not be here.

This will cause a md5 hash mismatch which can have negative side effects like leaderboards not working on older/converted maps.

@WilliamQiufeng WilliamQiufeng requested a review from Swan November 2, 2024 13:43
@Swan Swan merged commit 815b5f8 into Quaver:master Nov 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants