Quality-of-life fixes #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .MD option was programmed to output the duration of each video, but this feature assumed that all videos had a definite duration between 0 seconds and 59:59. This fails for live streams, which report a duration of -1, so the MD exporter incorrectly labelled this with (-1:59). To counter this, .MD now labels live streams with the indication (LIVE) instead of a time, and prints no indication if the video is not a live stream, but the duration is a negative number. It also labels correctly videos over an hour, and labels videos over one day as d:hh:mm:ss. The MU8 format was not affected by this bug, as the duration must always be specified, and -1 is the standard value for "not applicable".
If the argument of this script ends in .zip (case-insensitive), it automatically extracts newpipe.db to a temporary directory, reads all necessary data from there, and then deletes the whole temporary directory. Instructions in the script have been updated to that effect.
Adding an explicit list to avoid a collision between streams.thumbnail_url and playlists.thumbnail_url. The downside to this method is that new values that NewPipe may add in the future are not added automatically to the JSON dump. Also corrected the description of the variable PlaylistDir at getPlaylists()
Adding a couple failsafes to the automatic ZIP extraction, and returning None, None when create_connection() raises an exception, to handle errors more cleanly.
|
Hi @medape I'm a bit packed at the moment but I will take a look, test and merge it as soon as I got time. |
|
Hi Medape I finally had time to look at your pull request! Features/changes tested:
I found two things that make the request not working on my end (see the review comments on the corresponding lines), the rest works as intended. Regarding the GUI, thanks for the input, I'll take at look at CITGuru/PyInquirer. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again! Thank you so much for accepting my last pull request. And for your appreciation.
You mentioned wanting to expand the script, maybe there is a way to make it so we can use the same code for a GUI, and for a CLI like CITGuru/PyInquirer? I don't know, it's a topic I never looked into a lot.
I'm planning to add a couple of CSV formats I'm going to make use for, but for now, I wanted to have you look if you're interested in these commits. Most of them are small tweaks and fixes.
The largest addition here is that now, if fed a .ZIP file, the extractor automatically checks if there is a
newpipe.dbfile weighing less than 1 GiB (uncompressed), and if so, extracts it to a temporary folder so as to save the user that "effort". There is a way to extract the file directly to memory, but I couldn't find the way to run SQL queries on that.