Try to get the list of drives and their contents #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HaudinFlorence
force-pushed
the
try_to_get_drive_contents
branch
from
d37efc2
to
b5cc12e
Compare
HaudinFlorence
force-pushed
the
try_to_get_drive_contents
branch
5 times, most recently
from
dce7bb9
to
410d05b
Compare
HaudinFlorence
force-pushed
the
try_to_get_drive_contents
branch
5 times, most recently
from
3017d48
to
3a3ca31
Compare
…with the default file browser and the added drive one.
…ddDrivesPlugin and moved hard coded inputs mimicking backend side inputs , outside from the plugins and methods.
Add logics to add the content of the drive to the filebrowser when adding a drive in the dialog.
…nterface, when picking a drive by its name in the list of available drives. Add a toolbar to all the drive filebrowsers.
Create a BreadCrumbsLayout to enable to have the breadcrumbs inside the AccordionPanel title section
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
…d remove non unnecessary files.
…panel containing a drive filebrowser.
… the informations about the list of drives and create the corresponding new Drive instances with faked contents at this stage.
…nd update index.ts and drivelistmanager to be able to add and remove panels containing drive filebrowsers for drives selected in the dialog.
…nt a drive. Try to get the content of this drive.
…t the content of a drive. Update index.ts. Update the get method of the Drive class in contents.ts to populate the drive filebrowser with the contents from the respective s3 bucket. Change the icon for the drive filebrowser.
HaudinFlorence
force-pushed
the
try_to_get_drive_contents
branch
14 times, most recently
from
8d508fa
to
2264322
Compare
|
Checking the UI tests report, it looks like the plugin does not activate due to: playwright-trace-demo.webm |
HaudinFlorence
force-pushed
the
try_to_get_drive_contents
branch
2 times, most recently
from
6acf446
to
0113eea
Compare
|
@jtpio Thanks for the screenshot and the help. It appears indeed that the activation message is not properly placed. |
Temporarily disable the browser-check test.
HaudinFlorence
force-pushed
the
try_to_get_drive_contents
branch
from
0113eea
to
7a2f10f
Compare
… createDrivesList.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries the connection between backend and frontend and tries to: