Skip to content

Commit

Permalink
ci: Fix testing without LTO
Browse files Browse the repository at this point in the history
The jobs matrix doesn't set any environment variables, so the
without-LTO job just set `CFLAGS` in the matrix, which was never used
for anything as intended.
  • Loading branch information
QuLogic committed Jan 30, 2025
1 parent 5510383 commit ec5316f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
"ipython==7.29.0"
"ipykernel==5.5.6"
"matplotlib-inline<0.1.7"
CFLAGS: "-fno-lto" # Ensure that disabling LTO works.
lto: "--config-settings=setup-args=-Db_lto=false" # Ensure that disabling LTO works.
# https://github.com/matplotlib/matplotlib/pull/26052#issuecomment-1574595954
# https://www.riverbankcomputing.com/pipermail/pyqt/2023-November/045606.html
pyqt6-ver: '!=6.5.1,!=6.6.0,!=6.7.1'
Expand Down Expand Up @@ -348,7 +348,7 @@ jobs:
fi
python -m pip install --no-deps --no-build-isolation --verbose \
--config-settings=setup-args="-DrcParams-backend=Agg" \
--config-settings=setup-args="-DrcParams-backend=Agg" ${{ matrix.lto }} \
--editable .[dev]
if [[ "${{ runner.os }}" != 'macOS' ]]; then
Expand Down

0 comments on commit ec5316f

Please sign in to comment.