Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation about instruction duration #13592

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add documentation about instruction duration #13592

wants to merge 4 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Dec 21, 2024

Summary

The deprecations introduced in #13247 did not notify via docs.

@coveralls
Copy link

coveralls commented Dec 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12884543646

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 88.959%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.48%
Totals Coverage Status
Change from base Build 12868603604: 0.03%
Covered Lines: 79443
Relevant Lines: 89303
💛 - Coveralls

@1ucian0 1ucian0 marked this pull request as ready for review December 24, 2024 14:09
@1ucian0 1ucian0 requested review from nonhermitian, a team, eggerdj and wshanks as code owners December 24, 2024 14:09
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

@1ucian0 1ucian0 added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Dec 24, 2024
ElePT
ElePT reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just added some minor grammatical suggestions.

qiskit/visualization/timeline/core.py Outdated Show resolved Hide resolved
qiskit/visualization/timeline/core.py Outdated Show resolved Hide resolved
qiskit/visualization/timeline/core.py Outdated Show resolved Hide resolved
qiskit/visualization/timeline/interface.py Outdated Show resolved Hide resolved
qiskit/circuit/instruction.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT left review comments

@nonhermitian nonhermitian Awaiting requested review from nonhermitian nonhermitian is a code owner

@eggerdj eggerdj Awaiting requested review from eggerdj eggerdj is a code owner

@wshanks wshanks Awaiting requested review from wshanks wshanks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1ucian0 @coveralls @qiskit-bot @ElePT