Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pydocstyle with Ruff (backport #692) #695

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 24, 2024

Pydocstyle was deprecated in favor of Ruff. Ruff has the exact same lints via the D ruleset.

As before, we only run the doc checks on source code and not tests.


This is an automatic backport of pull request #692 done by Mergify.

* Replace pycodestyle with Ruff

* Call ruff a single time

* Add description of `inplace` argument to `decompose_qpd_instructions`

* Simplify things

* Update QPDGate docstrings

* Use `extend-select` instead of `select`

---------

Co-authored-by: Jim Garrison <[email protected]>
(cherry picked from commit 0415fc6)

# Conflicts:
#	pyproject.toml
@mergify mergify bot added the conflicts label Oct 24, 2024
Copy link
Author

mergify bot commented Oct 24, 2024

Cherry-pick of 0415fc6 has failed:

On branch mergify/bp/stable/0.9/pr-692
Your branch is up to date with 'origin/stable/0.9'.

You are currently cherry-picking commit 0415fc6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/conf.py
	modified:   qiskit_addon_cutting/__init__.py
	modified:   qiskit_addon_cutting/cut_finding/cutting_actions.py
	modified:   qiskit_addon_cutting/cut_finding/lo_cuts_optimizer.py
	modified:   qiskit_addon_cutting/cutting_decomposition.py
	modified:   qiskit_addon_cutting/cutting_experiments.py
	modified:   qiskit_addon_cutting/cutting_reconstruction.py
	modified:   qiskit_addon_cutting/qpd/decompose.py
	modified:   qiskit_addon_cutting/qpd/decompositions.py
	modified:   qiskit_addon_cutting/qpd/instructions/qpd_gate.py
	modified:   qiskit_addon_cutting/qpd/qpd_basis.py
	modified:   qiskit_addon_cutting/qpd/weights.py
	modified:   qiskit_addon_cutting/utils/__init__.py
	modified:   qiskit_addon_cutting/utils/bitwise.py
	modified:   qiskit_addon_cutting/utils/iteration.py
	modified:   qiskit_addon_cutting/utils/observable_grouping.py
	modified:   qiskit_addon_cutting/utils/simulation.py
	modified:   qiskit_addon_cutting/utils/transforms.py
	modified:   qiskit_addon_cutting/utils/transpiler_passes.py
	modified:   tox.ini

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pyproject.toml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11504884065

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11504851603: 0.0%
Covered Lines: 2330
Relevant Lines: 2330

💛 - Coveralls

@Eric-Arellano
Copy link
Collaborator

Eric-Arellano commented Oct 24, 2024

FYI @garrison I realized we don't need this cherry-picked after all. The new approach I'm taking for the API docs avoids the problem.

But doesn't hurt to cherry-pick

@Eric-Arellano Eric-Arellano merged commit 658112f into stable/0.9 Oct 28, 2024
11 checks passed
@Eric-Arellano Eric-Arellano deleted the mergify/bp/stable/0.9/pr-692 branch October 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants