Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to EstimatorV2 in tests #644

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Migrate to EstimatorV2 in tests #644

merged 3 commits into from
Jul 19, 2024

Conversation

garrison
Copy link
Member

Partially addresses #506.

@garrison garrison added the tests Related to tests label Jul 17, 2024
@coveralls
Copy link

coveralls commented Jul 17, 2024

Pull Request Test Coverage Report for Build 9995759082

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9980490655: 0.0%
Covered Lines: 2410
Relevant Lines: 2410

💛 - Coveralls

garrison added 2 commits July 17, 2024 17:19
The previous code passed `observables_nophase` to the cutting code,
so it wasn't even testing the phases through the workflow.  The
correct way to handle such observables with nontrivial phase is to
use the utility introduced in #587.
@garrison
Copy link
Member Author

I made it so all the observables have trivial phase. As I mentioned in e8dd340:

The previous code passed observables_nophase to the cutting code, so it wasn't even testing the phases through the workflow. The correct way to handle such observables with nontrivial phase is to use the utility introduced in #587.

@garrison garrison requested a review from ibrahim-shehzad July 18, 2024 22:06
Copy link
Collaborator

@ibrahim-shehzad ibrahim-shehzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@garrison garrison merged commit cad1f2d into main Jul 19, 2024
11 checks passed
@garrison garrison deleted the estimatorv2-tests branch July 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants