Skip to content

Commit

Permalink
Test that persistent-volume is writable under Docker Compose (#550)
Browse files Browse the repository at this point in the history
* Test that `persistent-volume` is writable under Docker Compose

The Docker test is expected to fail before #548 is merged and to succeed after it is merged.

* Run docker tests when `workflows/docker.yml` changes
  • Loading branch information
garrison authored Apr 14, 2024
1 parent 03d4ae8 commit 3838c7c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ name: Docker notebook tests
on:
push:
branches: [ main ]
paths: ['Dockerfile', '.dockerignore', 'compose.yaml']
paths: ['Dockerfile', '.dockerignore', 'compose.yaml', '.github/workflows/docker.yml']
pull_request:
branches: [ main ]
paths: ['Dockerfile', '.dockerignore', 'compose.yaml']
paths: ['Dockerfile', '.dockerignore', 'compose.yaml', '.github/workflows/docker.yml']
schedule:
- cron: '0 20 * * 3'

Expand All @@ -21,3 +21,6 @@ jobs:
- name: Test notebooks
shell: bash
run: docker compose run notebook "bash" "-c" "pip install pytest nbmake && pytest --nbmake docs"
- name: Test that persistent-volume is writable
shell: bash
run: docker compose run notebook "bash" "-c" "touch persistent-volume/empty-notebook.ipynb"

0 comments on commit 3838c7c

Please sign in to comment.