fix deadlock when binlog offset of slave partition is larger than master

Qihoo360 · Jan 15, 2018 · 4ceebc6 · 4ceebc6
1 parent 4ed1c44
commit 4ceebc6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/node/zp_data_partition.cc b/src/node/zp_data_partition.cc
@@ -595,8 +595,8 @@ void Partition::BecomeSlave() {
 
 // Get binlog offset when I win the election
 // Return false if I'm not a master
+// Requeired: hold read lock of state_rw_
 bool Partition::GetWinBinlogOffset(BinlogOffset* win) {
-  slash::RWLock l(&state_rw_, false);
   if (role_ != Role::kNodeMaster) {
     return false;
   }