Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHELL] Fix the bug that spark-shell of XSQL cann't start #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WeiWenda
Copy link
Collaborator

@WeiWenda WeiWenda commented Sep 16, 2019

What changes were proposed in this pull request?
As jline has be pre-configured in spark-parent by dependencyManagement, we should not set a different version of jline in spark-shell again. What's more, jline has been packaged by spark-assembly, there is no need to shade it into spark-shell jar in XSQL plugin version.

@beliefer
Copy link
Collaborator

Could you add What changes were proposed in this pull request? ? you can reference the other PR.

@beliefer beliefer added improve Improvements to function bug Something isn't working and removed improve Improvements to function labels Sep 16, 2019
@beliefer
Copy link
Collaborator

beliefer commented Sep 17, 2019

I think we should recurrent this issue and then supplement the description of issue.

@beliefer beliefer changed the title [CORE] Fix the bug that spark-shell of XSQL cann't start [SHELL] Fix the bug that spark-shell of XSQL cann't start Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants