Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: use cache.ped, notify, convar locale switch, convert commands to ox_lib #6

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Conversation

mockdot
Copy link
Member

@mockdot mockdot commented Jul 27, 2023

Description

  • Use ox_lib cache.ped
  • Convert notifies back to Notify
  • Add convar locale switch
  • Convert commands to ox_lib

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

@TonybynMp4
Copy link
Contributor

Don't convert to notifyV2

@mockdot
Copy link
Member Author

mockdot commented Jul 27, 2023

Don't convert to notifyV2

Already reverted to Notify

@mockdot mockdot changed the title fixes: use cache.ped, notifyV2, convar locale switch, convert commands to ox_lib fixes: use cache.ped, notify, convar locale switch, convert commands to ox_lib Jul 27, 2023
@TonybynMp4
Copy link
Contributor

Don't convert to notifyV2

Already reverted to Notify

careful tho the arguments are passed incorrectly

@mockdot
Copy link
Member Author

mockdot commented Jul 27, 2023

Don't convert to notifyV2

Already reverted to Notify

careful tho the arguments are passed incorrectly

How so? description seems to have been replaced by text now, if you look at Chat's latest qbx-core changes

@TonybynMp4
Copy link
Contributor

TonybynMp4 commented Jul 27, 2023

it's either {text = '', caption = ''} or it's like it's always been, in your case there's no point in using the table form since you only send the text + you're putting everything in the table when that's not at all how it works

@TonybynMp4
Copy link
Contributor

still not 😭 it's Notify(text, type, duration) it didn't change lol

@TonybynMp4
Copy link
Contributor

Amen

@ChatDisabled ChatDisabled merged commit e0ef504 into Qbox-project:main Jul 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants