Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder files and Config "enum" like changes #28

Merged
merged 12 commits into from
Nov 18, 2023

Conversation

adweex
Copy link
Contributor

@adweex adweex commented Nov 18, 2023

Description

Created the shared and modules folder as placeholder. Also changes to the config based on previous conversations.
#23

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

@Manason
Copy link
Member

Manason commented Nov 18, 2023

What modules do you plan to provide for vehicle keys?

config.lua Outdated Show resolved Hide resolved
@adweex
Copy link
Contributor Author

adweex commented Nov 18, 2023

What modules do you plan to provide for vehicle keys?

Truth is i have no idea. You said this in the previous pull request.

" Consider further modifications to config similar to qbx_core:
Split into client, server, and shared files
Make into modules"

Still trying to decode that. These modules are new to me :D

@Manason
Copy link
Member

Manason commented Nov 18, 2023

What modules do you plan to provide for vehicle keys?

Truth is i have no idea. You said this in the previous pull request.

" Consider further modifications to config similar to qbx_core: Split into client, server, and shared files Make into modules"

Still trying to decode that. These modules are new to me :D

Oh. Take a look at the qbx_core/config folder and copy the way core does configs. You can delete the modules/ folder

modules/modulesPlaceholder.lua Outdated Show resolved Hide resolved
shared/functions.lua Outdated Show resolved Hide resolved
@adweex
Copy link
Contributor Author

adweex commented Nov 18, 2023

What modules do you plan to provide for vehicle keys?

Truth is i have no idea. You said this in the previous pull request.
" Consider further modifications to config similar to qbx_core: Split into client, server, and shared files Make into modules"
Still trying to decode that. These modules are new to me :D

Oh. Take a look at the qbx_core/config folder and copy the way core does configs. You can delete the modules/ folder

Oh. I see. So you sort the configs to client only, server only and shared config values. That's sort of new. I've seen this return {} config thingy on ox scripts, so qbx implemented these as well. How do i refer to these config values? So it's not Config.x anymore.

Like this?
local config = require 'config.client'

@adweex adweex requested a review from Manason November 18, 2023 10:16
config.lua Outdated Show resolved Hide resolved
config/client.lua Outdated Show resolved Hide resolved
fxmanifest.lua Show resolved Hide resolved
fxmanifest.lua Outdated Show resolved Hide resolved
config/client.lua Outdated Show resolved Hide resolved
@Manason
Copy link
Member

Manason commented Nov 18, 2023

What modules do you plan to provide for vehicle keys?

Truth is i have no idea. You said this in the previous pull request.
" Consider further modifications to config similar to qbx_core: Split into client, server, and shared files Make into modules"
Still trying to decode that. These modules are new to me :D

Oh. Take a look at the qbx_core/config folder and copy the way core does configs. You can delete the modules/ folder

Oh. I see. So you sort the configs to client only, server only and shared config values. That's sort of new. I've seen this return {} config thingy on ox scripts, so qbx implemented these as well. How do i refer to these config values? So it's not Config.x anymore.

Like this? local config = require 'config.client'

Yep

@adweex adweex requested a review from Manason November 18, 2023 22:39
@Manason Manason merged commit e7fc8a2 into Qbox-project:main Nov 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants