forked from zcash/halo2
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OrchardZSA backward compatability using traits (#31)
This commit contains the following modifications: - Add tests for Lookup, ECC, Merkle, and Sinsemilla to verify that the verification key and the proof have not been modified by comparing them to those saved in a file. - Introduce a `LookupRangeCheck` trait that provides common methods for a lookup range check. - Use this new trait as a generic parameter in configs, chips and tests that are using lookup. - Create a new Lookup chip which is optimized for 4, 5 and 10-bit range check and add tests for this new chip. - Add `init_from_private_point` parameter in `SinsemillaConfig`. If this parameter is set to false, the `SinsemillaChip` is the same as the current `SinsemillaChip` used in vanilla circuit. Otherwise, the `SinsemillaChip` is modified to support hash from private point. --------- Co-authored-by: YaoGalteland <[email protected]> Co-authored-by: Dmitry Demin <[email protected]> Co-authored-by: Constance Beguier <[email protected]>
- Loading branch information
1 parent
5f436dc
commit 1195c9a
Showing
52 changed files
with
56,515 additions
and
1,499 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,33 +125,34 @@ jobs: | |
- name: Test halo2 book | ||
run: mdbook test -L target/debug/deps book/ | ||
|
||
# codecov: | ||
# name: Code coverage | ||
# runs-on: ubuntu-latest | ||
# | ||
# steps: | ||
# - uses: actions/checkout@v3 | ||
# # Use stable for this to ensure that cargo-tarpaulin can be built. | ||
# - id: prepare | ||
# uses: ./.github/actions/prepare | ||
# with: | ||
# toolchain: stable | ||
# nightly-features: true | ||
# - name: Install cargo-tarpaulin | ||
# uses: actions-rs/cargo@v1 | ||
# with: | ||
# command: install | ||
# args: cargo-tarpaulin | ||
# - name: Generate coverage report | ||
# uses: actions-rs/cargo@v1 | ||
# with: | ||
# command: tarpaulin | ||
# args: > | ||
# ${{ steps.prepare.outputs.feature-flags }} | ||
# --timeout 600 | ||
# --out Xml | ||
# - name: Upload coverage to Codecov | ||
# uses: codecov/[email protected] | ||
codecov: | ||
name: Code coverage | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
# Use stable for this to ensure that cargo-tarpaulin can be built. | ||
- id: prepare | ||
uses: ./.github/actions/prepare | ||
with: | ||
toolchain: stable | ||
nightly-features: true | ||
- name: Install cargo-tarpaulin | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
command: install | ||
args: cargo-tarpaulin | ||
- name: Generate coverage report | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
command: tarpaulin | ||
# Extend the timeout to 3600 to ensure the code coverage test pass | ||
args: > | ||
${{ steps.prepare.outputs.feature-flags }} | ||
--timeout 3600 | ||
--out Xml | ||
- name: Upload coverage to Codecov | ||
uses: codecov/[email protected] | ||
|
||
doc-links: | ||
name: Intra-doc links | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.