Update gradle #33
Draft
Update gradle #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update-gradle
update-gradle
update-gradle
update-gradle
update-gradle
ninovanhooff
commented
Dec 24, 2024
There was a problem hiding this comment.
WARNING Make sure CI can build this.
JitCi's dropdown does not seem to provide jdk 21
https://jitci.com/gh/Q42/Q42Stats.Android
But a yml file may be the solution... jitpack/jitpack.io#6479
If we want to stay on JitPack instead of Maven in the first place
#29
UPDATE
None of the methods I tried in this branch to get jitpack to use jdk 17 or 21 worked
update-gradle
update-gradle
ninovanhooff
force-pushed
the
update-gradle
branch
from
4a039c0 to
823a5e6
Compare
update-gradle
update-gradle
update-gradle
update-gradle
ninovanhooff
commented
Dec 24, 2024
jitpack.yml
Outdated
| jdk: | ||
| - openjdk17 | ||
| before_install: | ||
| - echo "Hello jitpack.yml before_install" |
There was a problem hiding this comment.
This file seems to not be picked up at all; I don't see this being printed to the logs
ninovanhooff
commented
Dec 24, 2024
q42stats/build.gradle
Outdated
| @@ -63,6 +68,24 @@ afterEvaluate { | |||
| // Applies the component for the release build variant. | |||
| from components.release | |||
|
|
|||
| pom { | |||
There was a problem hiding this comment.
This seems not to work, Jitpack still builds using java 11
update-gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.