Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add exact line-search for (f)gw solvers with kl_loss #556

Merged

Conversation

cedricvincentcuaz
Copy link
Collaborator

Types of changes

  • Add exact line-search for ot.gromov.gromov_wasserstein and ot.gromov.fused_gromov_wasserstein when loss_fun = 'kl_loss' which can be called by setting armijo=False(default for the method). Note that these solvers ignored the provided armijo parameter with this loss enforcing armijo=True.
  • Extend ot.gromov.solve_gromov_linesearch to any loss with common decomposition.
  • Adapt the behavior of dependent solvers that also enforced armijo=True: ot.gromov.gromov_barycenters and ot.gromov.fgw_barycenters
  • Add gradients in this setting for ot.gromov.gromov_wasserstein2 and ot.gromov.fused_gromov_wasserstein2

Motivation and context / Related issue

How has this been tested (if it applies)

  • Extended existing test for ot.gromov.gromov_wasserstein and ot.gromov.fused_gromov_wasserstein with kl loss, looping over armijo values.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #556 (e3f35cd) into master (53dde7a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files          67       67           
  Lines       14663    14663           
=======================================
  Hits        14149    14149           
  Misses        514      514           

@cedricvincentcuaz cedricvincentcuaz merged commit a73ad08 into PythonOT:master Nov 4, 2023
13 checks passed
@cedricvincentcuaz cedricvincentcuaz deleted the semirelaxed_gromov branch November 4, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant