[MRG] Add exact line-search for (f)gw solvers with kl_loss #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
ot.gromov.gromov_wasserstein
andot.gromov.fused_gromov_wasserstein
whenloss_fun = 'kl_loss'
which can be called by settingarmijo=False
(default for the method). Note that these solvers ignored the providedarmijo
parameter with this loss enforcingarmijo=True
.ot.gromov.solve_gromov_linesearch
to any loss with common decomposition.armijo=True
:ot.gromov.gromov_barycenters
andot.gromov.fgw_barycenters
ot.gromov.gromov_wasserstein2
andot.gromov.fused_gromov_wasserstein2
Motivation and context / Related issue
How has this been tested (if it applies)
ot.gromov.gromov_wasserstein
andot.gromov.fused_gromov_wasserstein
with kl loss, looping over armijo values.PR checklist