Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU support #88

Open
wants to merge 3 commits into
base: mlSearcher
Choose a base branch
from
Open

GPU support #88

wants to merge 3 commits into from

Conversation

Parzival-05
Copy link

@Parzival-05 Parzival-05 commented Dec 24, 2024

Copy link
Member

@gsvgit gsvgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current configuration of F# formatter leads to ugly code.

@@ -133,6 +135,8 @@ public readonly record struct VSharpOptions
/// <param name="stepsLimit">Number of symbolic machine steps to stop execution after. Zero value means no limit.</param>
/// <param name="aiAgentTrainingOptions">Settings for AI searcher training.</param>
/// <param name="pathToModel">Path to ONNX file with model to use in AI searcher.</param>
/// <param name="useGPU">Enables GPU processing.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU processing for what?

@@ -133,6 +135,8 @@ public readonly record struct VSharpOptions
/// <param name="stepsLimit">Number of symbolic machine steps to stop execution after. Zero value means no limit.</param>
/// <param name="aiAgentTrainingOptions">Settings for AI searcher training.</param>
/// <param name="pathToModel">Path to ONNX file with model to use in AI searcher.</param>
/// <param name="useGPU">Enables GPU processing.</param>
/// <param name="optimize">Optimize.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimize what?

then None
elif Seq.length availableStates = 1
then Some (Seq.head availableStates)
elif Seq.length availableStates = 0 then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really ugly style.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantomas has no way to move to the next line. Or I didn't search well.
https://fsprojects.github.io/fantomas/docs/end-users/Configuration.html#Auxiliary-settings

And yet, it seems that this style fits perfectly into the Microsoft manual: https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/formatting#multiline-bracket-formatting-styles.

VSharp.Explorer/Explorer.fs Outdated Show resolved Hide resolved
elif hasTimeout then
int explorationOptions.timeout.TotalMilliseconds
/ 2
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Some this
else None
else
None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Some method
else
None
| _ -> None
else Some methodBase
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

VSharp.Explorer/Options.fs Outdated Show resolved Hide resolved
VSharp.Explorer/Options.fs Outdated Show resolved Hide resolved
VSharp.ML.GameServer.Runner/Main.fs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants