-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU support #88
base: mlSearcher
Are you sure you want to change the base?
GPU support #88
Conversation
d2b50a7
to
e5544e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current configuration of F# formatter leads to ugly code.
VSharp.API/VSharpOptions.cs
Outdated
@@ -133,6 +135,8 @@ public readonly record struct VSharpOptions | |||
/// <param name="stepsLimit">Number of symbolic machine steps to stop execution after. Zero value means no limit.</param> | |||
/// <param name="aiAgentTrainingOptions">Settings for AI searcher training.</param> | |||
/// <param name="pathToModel">Path to ONNX file with model to use in AI searcher.</param> | |||
/// <param name="useGPU">Enables GPU processing.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPU processing for what?
VSharp.API/VSharpOptions.cs
Outdated
@@ -133,6 +135,8 @@ public readonly record struct VSharpOptions | |||
/// <param name="stepsLimit">Number of symbolic machine steps to stop execution after. Zero value means no limit.</param> | |||
/// <param name="aiAgentTrainingOptions">Settings for AI searcher training.</param> | |||
/// <param name="pathToModel">Path to ONNX file with model to use in AI searcher.</param> | |||
/// <param name="useGPU">Enables GPU processing.</param> | |||
/// <param name="optimize">Optimize.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize what?
then None | ||
elif Seq.length availableStates = 1 | ||
then Some (Seq.head availableStates) | ||
elif Seq.length availableStates = 0 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is really ugly style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantomas has no way to move to the next line. Or I didn't search well.
https://fsprojects.github.io/fantomas/docs/end-users/Configuration.html#Auxiliary-settings
And yet, it seems that this style fits perfectly into the Microsoft manual: https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/formatting#multiline-bracket-formatting-styles.
elif hasTimeout then | ||
int explorationOptions.timeout.TotalMilliseconds | ||
/ 2 | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
Some this | ||
else None | ||
else | ||
None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
Some method | ||
else | ||
None | ||
| _ -> None | ||
else Some methodBase | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
e5544e9
to
fb3674a
Compare
83c2521
to
b2add77
Compare
See the main changes here: fb3674a