Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Py3k #8

Closed
wants to merge 15 commits into from
Closed

Update Py3k #8

wants to merge 15 commits into from

Conversation

NicolasSandoval
Copy link
Member

@reingart
Copy link
Member

I would recommend to not mix several issues (tickets) in a single PR, except they were trivial or highly related.
This could be confusing and will scare reviewers.

In this PR, up to commit af9da9b is ok, but the rest seems unrelated to ticket #3

Please open different PR for da580ef & 37f6d28 (mostly automatic changes due PEP8 issues), and don't forget to open a new ticket explaining what steps/tool did you use

3528d49 should be in a different PR too, as it changes the dependencies (requeriments #2) and this is something that often needs extra review / tests and approvals

@NicolasSandoval
Copy link
Member Author

Thanks for the suggestions. As soon as possible, I will make the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants