refactor(resources): Use constants for readability

PurdueRCAC · Mar 27, 2024 · 129f186 · 129f186
1 parent d16b100
commit 129f186
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/app/Modules/Resources/Console/EmailSchedulingCommand.php b/app/Modules/Resources/Console/EmailSchedulingCommand.php
@@ -45,7 +45,7 @@ public function handle(): void
 			->join($c, $c . '.subresourceid', $s . '.id')
 			->join($a, $a . '.id', $c . '.resourceid')
 			->whereNull($a . '.datetimeremoved')
-			->where($s . '.notice', '=', 2)
+			->where($s . '.notice', '=', Subresource::NOTICE_JUST_STOPPED)
 			->get();
 
 		if (count($stopped))
@@ -72,7 +72,7 @@ public function handle(): void
 
 				foreach ($stopped as $subresource)
 				{
-					$subresource->update(['notice' => 3]);
+					$subresource->update(['notice' => Subresource::NOTICE_STILL_STOPPED]);
 				}
 			}
 		}
@@ -86,15 +86,15 @@ public function handle(): void
 			->join($c, $c . '.subresourceid', $s . '.id')
 			->join($a, $a . '.id', $c . '.resourceid')
 			->whereNull($a . '.datetimeremoved')
-			->where($s . '.notice', '=', 1)
+			->where($s . '.notice', '=', Subresource::NOTICE_JUST_STARTED)
 			->get();
 
 		$stopped = Subresource::query()
 			->select($s . '.*')
 			->join($c, $c . '.subresourceid', $s . '.id')
 			->join($a, $a . '.id', $c . '.resourceid')
 			->whereNull($a . '.datetimeremoved')
-			->where($s . '.notice', '=', 3)
+			->where($s . '.notice', '=', Subresource::NOTICE_STILL_STOPPED)
 			->get();
 
 		if (count($started))
@@ -123,7 +123,7 @@ public function handle(): void
 
 			foreach ($started as $subresource)
 			{
-				$subresource->update(['notice' => 0]);
+				$subresource->update(['notice' => Subresource::NO_NOTICE]);
 			}
 		}
 		elseif ($debug || $this->output->isVerbose())