Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Add single-line installation command #37

Closed
wants to merge 1 commit into from
Closed

Add single-line installation command #37

wants to merge 1 commit into from

Conversation

Rafficer
Copy link
Contributor

@Rafficer Rafficer commented Mar 25, 2018

For usabilities sake. Maybe there's a more beautiful version than calling those commands one after another. Didn't work for me with wget -qO- ... and | bash -s -- -install

Also more beautiful would be to put those commands in an extra file, maybe even hosted on protonvpn.com and doing wget -qO- https://protonvpn.com/support/linuxinstall | bash

I just tested this. wget -qO- https://ncrypt.sh/linuxinstall_test | bash looks a lot more beautiful and works the same.

I also thought about adding echo "Initialize protonvpn-cli now with sudo protonvpn-cli -init" at the end of the installation function, to make it more clear, but wanted to hear thoughts on that first :)

@mazen160
Copy link
Collaborator

HI @Rafficer

Thanks for the PR!

I will discuss the approach with the team, I would prefer using git so it's more clear to users.

Maybe we finish the next build, there is another installation method that are simpler.

We can use:

sudo bash -c "git clone https://github.com/ProtonVPN/protonvpn-cli.git ; ./protonvpn-cli/protonvpn-cli.sh -install"

In addition to the current one.

@Rafficer
Copy link
Contributor Author

We can use:
sudo bash -c "git clone https://github.com/ProtonVPN/protonvpn-cli.git ; ./protonvpn-cli/protonvpn-cli.sh -install"
In addition to the current one.

Sounds good to me :)

Maybe also consider to add wget -qO- https://ncrypt.sh/linuxinstall_test | bash (obviously on protonvpn.com) on the support page as alternative quick install.

@mazen160
Copy link
Collaborator

Definitely we will have a simpler installation method in the future.
We have on long-term at #27

mazen160 added a commit that referenced this pull request Mar 26, 2018
@mazen160
Copy link
Collaborator

Done ;)
Thank you again @Rafficer !

@mazen160 mazen160 closed this Mar 26, 2018
@Rafficer Rafficer deleted the dev_singlecommand branch March 29, 2018 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants